Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9680#discussion_r44973809
--- Diff: R/pkg/R/functions.R ---
@@ -259,6 +259,20 @@ setMethod("column",
function(x) {
col(x)
})
+#' corr
+#'
+#' Computes the Pearson Correlation Coefficient for two Columns.
+#'
+#' @rdname corr
+#' @name corr
+#' @family math_funcs
+#' @export
+#' @examples \dontrun{corr(df$c, df$d)}
+setMethod("corr", signature(x = "Column", col1 = "Column", col2 =
"missing", method = "missing"),
--- End diff --
right, I like the approach of changing the existing generic definition.
perhaps we should align the method signature with the stats::cor
```
cor(x, y = NULL, use = "everything",
method = c("pearson", "kendall", "spearman"))
```
do you know why we decide to name it `corr` (vs. `cor`) in other places?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
