Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9680#discussion_r45019825
--- Diff: R/pkg/R/functions.R ---
@@ -259,6 +259,20 @@ setMethod("column",
function(x) {
col(x)
})
+#' corr
+#'
+#' Computes the Pearson Correlation Coefficient for two Columns.
+#'
+#' @rdname corr
+#' @name corr
+#' @family math_funcs
+#' @export
+#' @examples \dontrun{corr(df$c, df$d)}
+setMethod("corr", signature(x = "Column", col1 = "Column", col2 =
"missing", method = "missing"),
--- End diff --
Thinking more about this, I think what's being added in #9366 matches
https://stat.ethz.ch/R-manual/R-devel/library/stats/html/cor.html better. When
we are adding that support in R we could add it as `cor` matching stats::cor.
Meanwhile I'll change `corr` to what you suggested with `function(x, ...)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
