Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9680#discussion_r45259387
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -259,6 +259,21 @@ setMethod("column",
               function(x) {
                 col(x)
               })
    +#' corr
    +#'
    +#' Computes the Pearson Correlation Coefficient for two Columns.
    +#'
    +#' @rdname corr
    +#' @name corr
    +#' @family math_funcs
    +#' @export
    +#' @examples \dontrun{corr(df$c, df$d)}
    +setMethod("corr", signature(x = "Column"),
    --- End diff --
    
    That's the same for `count`, `max`, `mean` and so on, so change we would 
need to change every function here - should we do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to