Github user GraceH commented on a diff in the pull request:
https://github.com/apache/spark/pull/9796#discussion_r45418928
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite
}
var apps = getApplications()
- // kill executor 1
- assert(sc.killExecutor(executors.head))
+ // kill executor 1, and actually nothing to kill
+ assert(!sc.killExecutor(executors.head))
--- End diff --
according to my understanding, the 1st case tries to kill 27. the 2nd one
is to kill 28. that is why the first one causes nothing to happen. the latter
case actually kills the executor successfully.
btw, we donot change the 'val executors' after the first assignment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
