Github user GraceH commented on a diff in the pull request:
https://github.com/apache/spark/pull/9796#discussion_r45412931
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite
}
var apps = getApplications()
- // kill executor 1
- assert(sc.killExecutor(executors.head))
+ // kill executor 1, and actually nothing to kill
+ assert(!sc.killExecutor(executors.head))
--- End diff --
@andrewor14 The executors.head is assigned beforehand. for example, you
have two executor ID {27,28}. Then, the first one(id 27) is killed with
replacement. But I guess the newly created executor cannot be with the same ID.
After that, you try to kill the header executor (id 27), it should return empty
list (since 27 has been in the pendingToRemove list). Am I right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
