Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9524#discussion_r45668650
  
    --- Diff: mllib/pom.xml ---
    @@ -125,6 +125,10 @@
           <groupId>org.apache.spark</groupId>
           <artifactId>spark-test-tags_${scala.binary.version}</artifactId>
         </dependency>
    +    <dependency>
    +      <groupId>org.codehaus.janino</groupId>
    +      <artifactId>janino</artifactId>
    +    </dependency>
    --- End diff --
    
    I thought it would be better to explicitly depend on it now that we are 
using rather than depending on a transitive inclusion from another component.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to