Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8714#discussion_r45691536
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -702,8 +712,6 @@ private[deploy] class Master(
worker.addExecutor(exec)
worker.endpoint.send(LaunchExecutor(masterUrl,
exec.application.id, exec.id, exec.application.desc, exec.cores,
exec.memory))
- exec.application.driver.send(ExecutorAdded(
- exec.id, worker.id, worker.hostPort, exec.cores, exec.memory))
--- End diff --
I think we should keep this one. The idea of `ExecutorAdded` is to notify
the application that the master has launched an executor for it. Then once the
executor starts running the master will send an `ExecutorUpdated` message to
the application, and we already do this when the master receives
`ExecutorStateChanged`.
It's probably not a big deal either way but it's probably a better use of
the different states.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
