Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/8714#discussion_r45693106
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -702,8 +712,6 @@ private[deploy] class Master(
worker.addExecutor(exec)
worker.endpoint.send(LaunchExecutor(masterUrl,
exec.application.id, exec.id, exec.application.desc, exec.cores,
exec.memory))
- exec.application.driver.send(ExecutorAdded(
- exec.id, worker.id, worker.hostPort, exec.cores, exec.memory))
--- End diff --
I think it would be better to notify application of `ExecutorAdded` only
when worker reports back executor state to `RUNNING`. Otherwise application
will possibly receive `ExecutorAdded` while worker is failed to add executor.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
