Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45768920
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1169,3 +1170,34 @@ object ComputeCurrentTime extends Rule[LogicalPlan] {
}
}
}
+
+/**
+ * Replace the `UpCast` expression by `Cast`, and throw exceptions if the
cast may truncate.
+ */
+object RemoveUpCast extends Rule[LogicalPlan] {
+ private def fail(from: DataType, to: DataType) = {
+ throw new AnalysisException(
+ s"Cannot up cast ${from.simpleString} to ${to.simpleString} as it
may truncate")
+ }
+
+ private def checkNumericPrecedence(from: DataType, to: DataType):
Boolean = {
+ val fromPrecedence = HiveTypeCoercion.numericPrecedence.indexOf(from)
+ val toPrecedence = HiveTypeCoercion.numericPrecedence.indexOf(to)
+ if (toPrecedence > 0 && fromPrecedence > toPrecedence) {
--- End diff --
`!(toPrecedence > 0 && fromPrecedence > toPrecedence)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
