Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9840#discussion_r45769130
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
 ---
    @@ -235,12 +236,13 @@ case class ExpressionEncoder[T](
     
         val plan = Project(Alias(unbound, "")() :: Nil, LocalRelation(schema))
         val analyzedPlan = SimpleAnalyzer.execute(plan)
    +    val optimizedPlan = SimplifyCasts(analyzedPlan)
    --- End diff --
    
    I wonder if we should just use the full optimizer here.  I guess for now it 
won't do anything, but since it should never change the answer and we might 
improve it later that might make more sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to