Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45830487
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1169,3 +1170,31 @@ object ComputeCurrentTime extends Rule[LogicalPlan] {
}
}
}
+
+/**
+ * Replace the `UpCast` expression by `Cast`, and throw exceptions if the
cast may truncate.
+ */
+object ResolveUpCast extends Rule[LogicalPlan] {
+ private def fail(from: Expression, to: DataType) = {
+ throw new AnalysisException(s"Cannot up cast `${from.prettyString}`
from " +
--- End diff --
Here I just use `prettyString` to show the field path like `a`, `a.b`,
should we also show the type path like we did before?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]