Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9973#discussion_r45905265
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -125,8 +129,14 @@ object JdbcUtils extends Logging {
dialect: JdbcDialect): Iterator[Byte] = {
val conn = getConnection()
var committed = false
+ val supportsTransactions = Try(
--- End diff --
PS I think you were commenting on the style, but I had suggested that this
needed more changes since it just swallows the exception. WDYT? see
https://github.com/apache/spark/pull/9973#discussion_r45894114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
