Github user CK50 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9973#discussion_r45907294
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -125,8 +129,14 @@ object JdbcUtils extends Logging {
dialect: JdbcDialect): Iterator[Byte] = {
val conn = getConnection()
var committed = false
+ val supportsTransactions = Try(
--- End diff --
Hi Sean, hi Reynold,
thanks for your comments!
I have added the blank, changed the title, but I am not sure what to
change this code to.
The idea is to swallow any exception. My intention is to make code
tolerant against flaky drivers and not risk the entire functionality in
case some driver did not properly implement some tiny aspect (like
transaction capabilties).
Can you please advice on how this should be handled? - I could also
remove the entire try-catch. Just thought this may give more stability.
Thanks,
Christian
On 25.11.2015 19:56, Reynold Xin wrote:
>
> In
>
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
> <https://github.com/apache/spark/pull/9973#discussion_r45905487>:
>
> > @@ -125,8 +129,14 @@ object JdbcUtils extends Logging {
> > dialect: JdbcDialect): Iterator[Byte] = {
> > val conn = getConnection()
> > var committed = false
> > + val supportsTransactions = Try(
>
> Sounds good!
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/9973/files#r45905487>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
