Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10101#discussion_r46399345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -509,6 +509,7 @@ private[sql] class JDBCRDD(
} catch {
case e: Exception => logWarning("Exception closing connection", e)
}
+ closed = true
--- End diff --
I think this should go at the top, right after it is checked. My reasoning
is that if close fails, it would let itself be called again, and that's not
obviously helpful, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
