Github user rh99 commented on the pull request:
https://github.com/apache/spark/pull/10101#issuecomment-162039294
All exceptions are caught anyway, so it will always reach the end (if there
is no Error).
My reasoning was: If the code was changed, and it would really throw an
exception somewhere in the middle, the location at the end is better, since the
variable "closed" should only be true, if all JDBC resources have been closed.
Otherwise the variable should have a name like "guard". Anyway either location
is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
