Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9756#discussion_r46604163
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/RegressionEvaluatorSuite.scala
---
@@ -65,15 +65,15 @@ class RegressionEvaluatorSuite
// default = rmse
val evaluator = new RegressionEvaluator()
- assert(evaluator.evaluate(predictions) ~== 0.1019382 absTol 0.001)
+ assert(evaluator.evaluate(predictions) ~== 0.1013829 absTol 0.001)
--- End diff --
It can't quite be based on the R results if the input is no longer the
same; even if it were it's not clear the thresholds were set in any principled
way, just looking at them.
I can see the argument that the tolerance should stay the same, because we
have a different but equally fixed new input. So, meh, toss up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
