Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10046#issuecomment-161785674
Actually... what's actually changing here? `conf` is not modified between
the old location of the code and the new location. The only place it's being
used is in the call to `configurable.setConf(conf)`; even ignoring the fact
that only a single InputFormat in Hadoop's sources implements Configurable
(`DBInputFormat`), I don't expect a method called `setConf` to modify its input
argument.
Have you seen any actual issue that is fixed by moving this code around?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
