Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/10046#issuecomment-161793722
  
    Can you put that in the PR description and the bug itself? From the change, 
it's not immediately clear what's being fixed. Also, changing the conf in 
`setConf` sounds really sketchy, and in a similar vein, `setConf` is free to do 
other things that this change would not address (e.g. clone the config and 
change the clone).
    
    I've seen input format classes that did sketchy things like this, and my 
suggestion to them was "use the configuration from the JobContext / 
TaskAttemptContext; that's how the API was meant to be used".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to