Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46623211
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -430,8 +476,50 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
newIterator.foreach(addIfAbsent)
oldIterator.foreach(addIfAbsent)
+ mergedApps
+ }
+
+
+ /**
+ * Scan through all the application attempts, if any have changed those
attempts
+ * will be updated with the new file sizes. No attempt to replay the
application
+ * is made; this is a low cost operation.
+ */
+ private[history] def updateAttemptFileSizes(): Unit = {
+ val now = System.currentTimeMillis();
+ val newAttempts: Iterable[FsApplicationAttemptInfo] = applications
+ .filter( e => !e._2.completed)
+ .flatMap { e =>
+ // build list of (false, attempt) or (true, attempt') values
--- End diff --
I think the comment is out-of-date ... looks like you are only updating the
individual attempts, not searching for new ones (and not returning a `(boolean,
attempt)`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
