Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46624212
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -73,4 +78,34 @@ private[history] abstract class
ApplicationHistoryProvider {
@throws(classOf[SparkException])
def writeEventLogs(appId: String, attemptId: Option[String], zipStream:
ZipOutputStream): Unit
+ /**
+ * Has an application attempt completed?
+ *
+ * The default returns the completed state of the history info
+ * @param appId application ID
+ * @param attemptId optional attempt ID
+ * @param applicationHistoryInfo the application being probed.
+ * @throws java.util.NoSuchElementException if there is no current
record of the application
+ * @return true if the application is considered to have completed
+ */
+ @throws(classOf[NoSuchElementException])
+ def isCompleted(appId: String,
+ attemptId: Option[String],
--- End diff --
nit: each arg on its own line (including the first one). here and lots of
other places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
