Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r46645061
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -699,12 +853,24 @@ private class FsApplicationAttemptInfo(
endTime: Long,
lastUpdated: Long,
sparkUser: String,
- completed: Boolean = true)
- extends ApplicationAttemptInfo(
- attemptId, startTime, endTime, lastUpdated, sparkUser, completed)
+ completed: Boolean = true,
+ val fileSize: Long = -1,
+ val instance: Long = -1)
--- End diff --
I don't see the point of `instance` and the `attemptCounter`. It seems
that it is eventually compared by a modified time (in
`FshistoryProvider#getAppUI`), I'm not sure why you don't just use the modified
time from the start. At least, in the tests, I replaced it w/ the modified
time and things still pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
