Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6935#discussion_r46673276
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -699,12 +853,24 @@ private class FsApplicationAttemptInfo(
         endTime: Long,
         lastUpdated: Long,
         sparkUser: String,
    -    completed: Boolean = true)
    -  extends ApplicationAttemptInfo(
    -      attemptId, startTime, endTime, lastUpdated, sparkUser, completed)
    +    completed: Boolean = true,
    +    val fileSize: Long = -1,
    +    val instance: Long = -1)
    --- End diff --
    
    modtime was proving too brittle. Not all updates were altering the 
modification time; I wasted a lot of time tying to de-brittalise tests to the 
point where I felt that while the test was working, I couldn't trust it in 
production. And I say that as the person who formally specified the Hadoop FS 
behaviours.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to