Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6935#discussion_r46995458
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
 ---
    @@ -73,4 +101,17 @@ private[history] abstract class 
ApplicationHistoryProvider {
       @throws(classOf[SparkException])
       def writeEventLogs(appId: String, attemptId: Option[String], zipStream: 
ZipOutputStream): Unit
     
    +  /**
    +   * Probe for an update to an (incompleted) application
    +   * @param appId application ID
    +   * @param attemptId optional attempt ID
    +   * @param updateTimeMillis time in milliseconds to use as the threshold 
for an update.
    +   * @param data any other data the operations implementation can use to 
determine age
    +   * @return true if the application was updated since `updateTimeMillis`
    +   */
    +  def isUpdated(appId: String, attemptId: Option[String], 
updateTimeMillis: Long,
    +      data: Option[HistoryProviderUpdateState]): Boolean = {
    --- End diff --
    
    nit: each arg on its own line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to