Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6935#issuecomment-162997974
thanks for updating and expanding the comments. I think I understand the
`version` better now. As I understand it, in the PR right now, the `version`
increases only if the file size increases. In fact, it seems that as far as
the code here is concerned, you could just replace the `version` with the file
size, and it would have the same effect. I can see perhaps wanting some more
general concept of `version` in the cache, but couldn't you just use file sizes
inside `FsHistoryProvider`?
Or if `version` is supposed to cover both timestamp & file size, I think
there needs to be a change in logic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
