Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47405512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -187,7 +184,7 @@ sealed abstract class AggregateFunction extends
Expression with ImplicitCastInpu
* `inputAggBufferOffset`, but not on the correctness of the attribute ids
in `aggBufferAttributes`
* and `inputAggBufferAttributes`.
*/
-abstract class ImperativeAggregate extends AggregateFunction {
+abstract class ImperativeAggregate extends AggregateFunction with
CodegenFallback {
--- End diff --
Recently I also tried this trick, but failed, because the eval() usually
only use attributes in the buffer, but BoundReference will try to look
attributes for child of AggregateFunction, which may not exists.
Could you have a test case for it? (using AggregateFunction as window
function)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
