Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47406421
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -70,15 +70,32 @@ trait CheckAnalysis {
failAnalysis(
s"invalid cast from ${c.child.dataType.simpleString} to
${c.dataType.simpleString}")
- case WindowExpression(UnresolvedWindowFunction(name, _), _) =>
- failAnalysis(
- s"Could not resolve window function '$name'. " +
- "Note that, using window functions currently requires a
HiveContext")
+ case w @ WindowExpression(AggregateExpression(_, _, true), _) =>
+ failAnalysis(s"Distinct window functions are not supported:
$w")
+
+ case w @ WindowExpression(_: OffsetWindowFunction,
WindowSpecDefinition(_, order,
+ SpecifiedWindowFrame(frame,
+ FrameBoundary(l),
+ FrameBoundary(h))))
+ if order.isEmpty || frame != RowFrame || l != h =>
+ failAnalysis("An offset window function can only be evaluated
in an ordered " +
--- End diff --
Should we allow `l` is `UnboundedPreceding ` and `h` is
`UnboundedFollowing` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
