Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r47551552
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -73,4 +102,18 @@ private[history] abstract class
ApplicationHistoryProvider {
@throws(classOf[SparkException])
def writeEventLogs(appId: String, attemptId: Option[String], zipStream:
ZipOutputStream): Unit
+ /**
+ * Probe for an update to an (incompleted) application
+ * @param appId application ID
+ * @param attemptId optional attempt ID
+ * @param updateState state information needed by the provider to
determine age
+ * @return true if the application has been updated
+ */
+ def isUpdated(
+ appId: String,
+ attemptId: Option[String],
+ updateState: Option[HistoryProviderUpdateState]): Boolean = {
+ false
--- End diff --
why provide a default implementation here? this is unlikely to be the
right implementation, just means somebody implementing this interface is more
likely to overlook supplying the right definition here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
