Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6935#discussion_r47551814
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -385,24 +448,48 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
}
- if (newAttempts.isEmpty) {
- return
+ updateApplicationsWithNewAttempts(newAttempts)
+ }
+
+ /**
+ * Merge in all new attempts with those in [[applications]], updating
the [[applications]]
+ * field afterwards. It _must not_ be executed concurrently, else
attempt information may
+ * be lost.
+ * @param newAttempts a possibly empty list of new attempts
+ */
+ private def updateApplicationsWithNewAttempts(newAttempts:
Iterable[FsApplicationAttemptInfo])
+ : Unit = {
--- End diff --
nit: move the arg to the second line, indent 4 spaces
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
