Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10058#discussion_r47577635
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -52,68 +53,80 @@ private[ui] class ExecutorsPage(
private val listener = parent.listener
def render(request: HttpServletRequest): Seq[Node] = {
- val storageStatusList = listener.storageStatusList
+ val activeStorageStatusList = listener.activeStorageStatusList
+ val activeExecutorsTable = listingExecTable(activeStorageStatusList,
true)
+ val deadStorageStatusList = listener.deadStorageStatusList
+ val deadExecutorsTable = listingExecTable(deadStorageStatusList, false)
+ val content =
+ <span>
+ <h4>ActiveExecutors({activeStorageStatusList.size})</h4>
{activeExecutorsTable}
+ <h4>DeadExecutors({deadStorageStatusList.size})</h4>
{deadExecutorsTable}
+ </span>
--- End diff --
can you put `{ }` around this? It makes the DSL a little less scary because
it guarantees that all the nodes are concatenated correctly together
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
