Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10208#discussion_r47625393
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -20,6 +20,7 @@ package org.apache.spark
import java.io.File
import com.google.common.io.Files
+import org.apache.commons.httpclient.util.URIUtil
--- End diff --
This only accidentally works since the library is a transitive dependency
of core. I'm hesitant to make it a direct dependency and make core yet bigger,
but in theory it already is (indirectly). It's not otherwise used in Spark
though.
I know we've been around a lot on this; I had though using the JDK URI
class directly was simplest rather than drag in a dependency. If anything I was
questioning wrapping it up in a method, but, that's not that bad.
Any other opinions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
