Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10208#discussion_r47679327
  
    --- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
    @@ -20,6 +20,7 @@ package org.apache.spark
     import java.io.File
     
     import com.google.common.io.Files
    +import org.apache.commons.httpclient.util.URIUtil
    --- End diff --
    
    Before you consider doing more work to change again, I'd love to get 
another opinion if possible. We won't stall too long on this in any event. I 
suppose I preferred your original change, yes, to this one, just because it 
avoids any new subtle dependency entanglement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to