Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10314#discussion_r47713626
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -93,7 +94,7 @@ private[spark] object SQLConf {
isPublic: Boolean = true): SQLConfEntry[Int] =
SQLConfEntry(key, defaultValue, { v =>
try {
- v.toInt
+ Utils.byteStringAsBytes(v).toInt
--- End diff --
Hello Sean: Thanks for your comment. Yes, you are right. There are other
methods are not meaning to use memory sizes. (like COLUMN_BATCH_SIZE, etc).
There are couple approaches, can you suggest which way is preferable way for
this problem or suggest a new way to fix this ?
1. we will document that [g|G|m|M|k|K] means memory size.
2. create a new method of intConf for AUTO_BROADCASTJOIN_THRESHOLD.
3. create a rule to the parseByteString. like K/KB/M/MB means 1024,
k/kb/m/mb means 1000.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
