Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10326#discussion_r47780896
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -308,6 +303,23 @@ private[spark] class CoarseMesosSchedulerBackend(
         }
       }
     
    +    // ToDo: Abstract out each condition and log them.
    +  def isOfferSatisfiesRequirements(slaveId: String, mem: Double, 
cpusOffered: Int,
    --- End diff --
    
    The name sounds a bit funny to me. Maybe just `offerSatisfiesRequirements`?
    
    Also, this might be `private`, or `private[spark]` to allow testing.
    
    Ideally the `TODO` would be implemented as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to