Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/10326#discussion_r47781199
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
---
@@ -328,6 +327,18 @@ private[spark] class MesosSchedulerBackend(
}
}
+ // check if all constraints are satisfied
+ // 1. Memory requirements
+ // 2. CPU requirements - need at least 1 for executor, 1 for task
+ def isOfferSatisfiesRequirements(cpusOffered: Double, memory : Double,
+ slaveId: String, sc : SparkContext):
Boolean = {
--- End diff --
Please use consistent style (and similar to the other places in the code).
Don't put a space between identifier and `:`. It should be `sc: SparkContext`,
not `sc : SparkContext`. There are several occurrences of this style in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
