Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10335#discussion_r47830240
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -210,6 +210,37 @@ case class Sort(
override def output: Seq[Attribute] = child.output
}
+case class Range(
+ start: Long,
+ end: Long,
+ step: Long,
+ numSlices: Int) extends LeafNode {
+ require(step != 0, "step cannot be 0")
+ val numElements: BigInt = {
+ val safeStart = BigInt(start)
+ val safeEnd = BigInt(end)
+ if ((safeEnd - safeStart) % step == 0 || safeEnd > safeStart ^ step >
0) {
+ (safeEnd - safeStart) / step
+ } else {
+ // the remainder has the same sign with range, could add 1 more
+ (safeEnd - safeStart) / step + 1
+ }
+ }
+
+ val output: Seq[Attribute] =
--- End diff --
I think it would be better to make this an argument to the constructor and
have a factory in the companion object that creates one automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
