Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10335#discussion_r47853387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -210,6 +210,37 @@ case class Sort(
override def output: Seq[Attribute] = child.output
}
+case class Range(
+ start: Long,
+ end: Long,
+ step: Long,
+ numSlices: Int) extends LeafNode {
+ require(step != 0, "step cannot be 0")
+ val numElements: BigInt = {
+ val safeStart = BigInt(start)
+ val safeEnd = BigInt(end)
+ if ((safeEnd - safeStart) % step == 0 || safeEnd > safeStart ^ step >
0) {
--- End diff --
I fully understood your concern. Readability and maintainability are always
very critical. If the others have the same comments, maybe we should also make
the same change in the RDD's Range API for ensuring them consistent?
Now, let me do the performance tests first. : ) Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
