Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10278#discussion_r47930611
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -265,7 +268,10 @@ private[sql] object ParquetFilters {
rhsFilter <- createFilter(schema, rhs)
} yield FilterApi.or(lhsFilter, rhsFilter)
- case sources.Not(pred) =>
+ // Here, we assume the Optimizer's rule BooleanSimplification has
pushed `Not` operator
+ // to the inner most level.
+ case sources.Not(pred)
+ if !pred.isInstanceOf[sources.And] &&
!pred.isInstanceOf[sources.Or] =>
--- End diff --
Yeah, your version is cleaner! Let me change the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
