Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10278#discussion_r47950692
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -256,6 +256,9 @@ private[sql] object ParquetFilters {
case sources.GreaterThanOrEqual(name, value) =>
makeGtEq.lift(dataTypeOf(name)).map(_(name, value))
+ case sources.In(name, valueSet) =>
+ makeInSet.lift(dataTypeOf(name)).map(_(name, valueSet.toSet))
+
case sources.And(lhs, rhs) =>
(createFilter(schema, lhs) ++ createFilter(schema,
rhs)).reduceOption(FilterApi.and)
--- End diff --
Looks like this is the real problem. It is not safe to just push one side
at here. This is the place where we drop that `In` because
`createFilter(schema, In(...))` returns `None`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
