Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10380#discussion_r48101417
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -60,20 +60,6 @@ object JdbcUtils extends Logging {
}
/**
- * Returns a PreparedStatement that inserts a row into table via conn.
--- End diff --
Hm, the only problem here is that this is a public method, and while it
feels like it was intended to be a Spark-only utility method, I'm not sure it's
marked as such.
It's not a big deal to retain it and implement in terms of the new method.
However it's now a function of a dialect, which is not an argument here. I
suppose any dialect will do since they all behave the same now. This method
could then be deprecated.
However: yeah, the behavior is actually the same for all dialects now.
Really, this has come full circle and can just be a modification to this
method, which was already the same for all dialects. Is there reason to believe
the insert statement might vary later? Then I could see keeping the current
structure here and just deprecating this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
