Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10380#discussion_r48132661
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -60,20 +60,6 @@ object JdbcUtils extends Logging {
}
/**
- * Returns a PreparedStatement that inserts a row into table via conn.
--- End diff --
That's a fair point, though I think the intent was to back-port this to
1.6.x at least, as it's a moderately important fix. Conceptually, I don't think
the API has changed; the insert statement is still not dialect-specific. Hence
it seems like the current API is even desirable to maintain for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
