Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10388#discussion_r48201572
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
 ---
    @@ -88,16 +88,27 @@ private[sql] object DataSourceStrategy extends Strategy 
with Logging {
             s"Selected $selected partitions out of $total, pruned 
$percentPruned% partitions."
           }
     
    +      // need to add projections from combineFilters in
    +      val combineFilter = combineFilters.reduceLeftOption(expressions.And)
    --- End diff --
    
    existing: `combine` is kind of a confusing name.  How about 
`partitionAndNormalColumnFilters`.  Its really long, but this code is pretty 
tough to follow.  I'd rather error on readability.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to