Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10388#discussion_r48201852
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
    @@ -194,4 +194,45 @@ class DataFrameNaFunctionsSuite extends QueryTest with 
SharedSQLContext {
         assert(out1(4) === Row("Amy", null, null))
         assert(out1(5) === Row(null, null, null))
       }
    +
    +  test("Spark-12231: dropna with partitionBy and groupBy") {
    --- End diff --
    
    It would be better to distill this down to its core and put the tests with 
the other DataSource tests.  In particular it seems like the actual but occurs 
when there are predicates that hit both partition and normal columns and 
nothing to do with `na.drop`.  Is that correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to