Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48209783
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
override def afterAll() {
yarnCluster.stop()
- System.clearProperty("SPARK_YARN_MODE")
+ System.setProperties(oldProperties)
super.afterAll()
--- End diff --
I agree. Since the original code did not use `try finally`, I did not use
it, too. Should I use `try finally`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
