Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10427#discussion_r48249668
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -180,14 +181,23 @@ class JDBCSuite extends SparkFunSuite
}
test("SELECT * WHERE (simple predicates)") {
- assert(stripSparkFilter(sql("SELECT * FROM foobar WHERE THEID <
1")).collect().size == 0)
- assert(stripSparkFilter(sql("SELECT * FROM foobar WHERE THEID !=
2")).collect().size == 2)
- assert(stripSparkFilter(sql("SELECT * FROM foobar WHERE THEID =
1")).collect().size == 1)
- assert(stripSparkFilter(sql("SELECT * FROM foobar WHERE NAME =
'fred'")).collect().size == 1)
- assert(stripSparkFilter(sql("SELECT * FROM foobar WHERE NAME >
'fred'")).collect().size == 2)
- assert(stripSparkFilter(sql("SELECT * FROM foobar WHERE NAME !=
'fred'")).collect().size == 2)
- assert(stripSparkFilter(sql("SELECT * FROM nulltypes WHERE A IS
NULL")).collect().size == 1)
- assert(stripSparkFilter(sql("SELECT * FROM nulltypes WHERE A IS NOT
NULL")).collect().size == 0)
+ def checkPlan(df: DataFrame): DataFrame = {
+ val parentPlan = df.queryExecution.executedPlan
+ // Check if SparkPlan Filter is removed in a physical plan and
+ // the plan only has PhysicalRDD to scan JDBCRelation.
--- End diff --
Actually you don't need to do so. `[[...]]` notation is only used in
ScalaDoc for adding links. It's not effective in inline comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
