Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10427#discussion_r48272857
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
 ---
    @@ -90,6 +90,11 @@ private[sql] case class JDBCRelation(
     
       override val schema: StructType = JDBCRDD.resolveTable(url, table, 
properties)
     
    +  // Check if JDBCRDD.compileFilter can accept input filters
    +  override def unhandledFilters(filters: Array[Filter]): Array[Filter] = {
    +    filters.filterNot(JDBCRDD.compileFilter(_) != null)
    --- End diff --
    
    Nit: It's a little bit weird to use double-negation here when 
`filters.filter(JDBCRDD.compileFilter(_) == null)` is perfectly OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to