Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10433#issuecomment-166616317
I think the logic is equivalent, yes, but it isn't any shorter or clearer.
Yes, the issue is that it looks strange to check if the state is FINISHED and
then otherwise check if it's a finished state (which means, a finished state
that isn't FINISHED). I don't think this is worth it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
