Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10433#issuecomment-166630101
I'm not suggesting any changes at all. If there were a few places in the
code that call for checking for a state that is "finished, but not FINISHED"
then I'd say it's worth making a name and method for that and refactoring this
and the other code to use it. For this alone, it doesn't seem like there's an
improvement.
I'm not arguing against improvements; I'm arguing against things that don't
appear to be an improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
