Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10454#discussion_r48386444
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -858,6 +859,30 @@ object PushPredicateThroughJoin extends 
Rule[LogicalPlan] with PredicateHelper {
     }
     
     /**
    +  * Push [[Limit]] operators through [[Join]] operators, iff the join type 
is outer joins.
    +  * Adding extra [[Limit]] operators on top of the outer-side 
child/children.
    +  */
    +object PushLimitThroughOuterJoin extends Rule[LogicalPlan] with 
PredicateHelper {
    --- End diff --
    
    oh, sorry. I was looking at the wrong line. For full outer join, is it 
safe? Also, with the limit, the result of left/right outer may not be 
deterministic, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to