Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48581487
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -252,6 +253,35 @@ private[ml] object TreeRegressorParams {
final val supportedImpurities: Array[String] =
Array("variance").map(_.toLowerCase)
}
+private[ml] trait DecisionTreeRegressorParams extends DecisionTreeParams
+ with TreeRegressorParams with HasVarianceCol {
+
+ /** @group setParam */
+ def setVarianceCol(value: String): this.type = set(varianceCol, value)
--- End diff --
This needs to be in the classes, not a trait, for Java compatibility. I'd
also note here that this is the biased sample variance (normalizing by number
of samples n, rather than n-1):
[https://en.wikipedia.org/wiki/Variance#Sample_variance]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
