Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8866#discussion_r48591785
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -113,6 +114,22 @@ final class DecisionTreeRegressionModel private[ml] (
rootNode.predictImpl(features).prediction
}
+ /** We need to update this function if we ever add other impurity
measures. */
+ protected def predictVariance(features: Vector): Double = {
+ rootNode.predictImpl(features).impurityStats.calculate()
+ }
+
+ override protected def transformImpl(dataset: DataFrame): DataFrame = {
+ val predictUDF = udf { (features: Vector) => predict(features) }
+ val predictVarianceUDF = udf { (features: Vector) =>
predictVariance(features) }
+ if (isDefined(varianceCol)) {
--- End diff --
We don't need to check ```predictionCol``` because it has been checked at
[```PredictionModel.transform```](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/Predictor.scala#L175).
Here we only need to add null string check for ```varianceCol```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
